-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sky remote integration #124507
Add Sky remote integration #124507
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello 👋🏻,
New integrations have to ue both a config flow and have that config flow 100% unit tested before being reviewed to be added to core. Please add the config flow.
def send_command(self, command: Iterable[str], **kwargs: Any) -> None: | ||
"""Send a list of commands to the device.""" | ||
try: | ||
self._remote.send_keys(command) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What can an user send with this integration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commands that can be sent are listed in the docs for the integration - https://github.com/home-assistant/home-assistant.io/pull/34419/files
@joostlek Would you like all these commits squashed? |
No need to squash, it will be squashed on merge. |
Co-authored-by: Kyle Cooke <[email protected]>
Added link to library |
Also, the brands PR is missing |
56ca901
to
3d46050
Compare
What's the difference between sky_hub and this? Are they the same device? |
Both are from the company Sky. This is a remote that allows control of Sky+HD and SkyQ satellite tv receivers over network. As both are made by sky they use the same brand images. |
im also saty9 on discord |
Proposed change
Adds the ability to send commands to a networked skyHD or skyq box.
Type of change
Additional information
Link to library: https://pypi.org/project/skyboxremote/
Link to brand PR: home-assistant/brands#6023
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
Documentation added/updated for www.home-assistant.io
https://github.com/dunnmj/home-assistant.io/tree/add-sky_remote-docs
Create sky_remote.markdown home-assistant.io#34419
If the code communicates with devices, web services, or third-party tools:
The manifest file has all fields filled out correctly.
Updated and included derived files by running:
python3 -m script.hassfest
.New or updated dependencies have been added to
requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.New dependency
To help with the load of incoming pull requests:
Co author @saty9 reviewed