Add Linkplay mTLS/HTTPS and improve logging #124307
Conversation
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Hey there @Velleman, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
dukeofphilberg
force-pushed
the
linkplay-0.0.7-changes
branch
from
f19d8d2 to
d69a5fe
Compare
MartinHjelmare
changed the title
|
Is that upadted now? |
Address old comments in 113940
Yes the necessary changes have been made in https://github.com/Velleman/python-linkplay/releases/tag/v0.0.9 and have now been implemented in this branch |
|
What's the next step for this pull request? |
|
Mostly not forgetting about it and pressing the merge button |
* Work * Implement 0.0.8 changes, fixup tests * Cleanup * Implement new playmodes, close clientsession upon ha close * Implement new playmodes, close clientsession upon ha close * Add test for zeroconf bridge failure * Bump 0.0.9 Address old comments in 113940 * Exact _async_register_default_clientsession_shutdown
| @@ -4,3 +4,4 @@ | |||
|
|
|||
| DOMAIN = "linkplay" | |||
| PLATFORMS = [Platform.MEDIA_PLAYER] | |||
| CONF_SESSION = "session" | |||
There was a problem hiding this comment.
We don't prefix constants with CONF_ unless it's a key used for configuration. Use eg DATA_SESSION instead.
* Work * Implement 0.0.8 changes, fixup tests * Cleanup * Implement new playmodes, close clientsession upon ha close * Implement new playmodes, close clientsession upon ha close * Add test for zeroconf bridge failure * Bump 0.0.9 Address old comments in 113940 * Exact _async_register_default_clientsession_shutdown
Proposed change
This PR adds new HTTPS/mTLS functionality for LinkPlay devices that do not support HTTPAPI over HTTP. This allows more devices such as the WiiM to work with HomeAssistant which was noted in #123088.
Specifically, constructing a
LinkPlayBridgenow happens throughlinkplay_factory_httpapi_bridge, which will automatically try both HTTPS and downstepping to HTTP. The function throws aLinkPlayRequestExceptionif noLinkPlayBridgewas able to be created, allowing for additional logging.Additionally, new media sources have been added and tests now use
@pytest.mark.usefixturesas per recommendation.Requires
python-linkplay==0.0.9to provide the async creation ofSSLContextandClientSessionthat loads the mTLS certificate. https://github.com/Velleman/python-linkplay/releases/tag/v0.0.9Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: