-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add advanced price attributes to price sensors in Amber Electric integration #124008
Conversation
Add support for price descriptors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please split this PR into two, one for bumping the dependency and changes to it, and one for adding the attributes.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
PR for dependency bump: #125701 |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Not stale, waiting for #125701 |
Superseded by #131945 |
Proposed change
Amber electric has added advanced forecasting prices to it's API feed. This PR adds these to price attributes.
As part of this, the integration uses version 2.0.0 of the amberelectric PyPi package, which has a different interface to version 1.x
Type of change
Checklist
ruff format homeassistant tests
)If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.Link to amberelectric.py release changelog: https://github.com/madpilot/amberelectric.py/releases/tag/v2.0.0
To help with the load of incoming pull requests: