Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add advanced price attributes to price sensors in Amber Electric integration #124008

Closed
wants to merge 36 commits into from

Conversation

madpilot
Copy link
Contributor

Proposed change

Amber electric has added advanced forecasting prices to it's API feed. This PR adds these to price attributes.

As part of this, the integration uses version 2.0.0 of the amberelectric PyPi package, which has a different interface to version 1.x

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

Link to amberelectric.py release changelog: https://github.com/madpilot/amberelectric.py/releases/tag/v2.0.0

To help with the load of incoming pull requests:

madpilot added 28 commits March 11, 2022 14:17
Copy link
Member

@jpbede jpbede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split this PR into two, one for bumping the dependency and changes to it, and one for adding the attributes.

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft September 10, 2024 20:52
@madpilot
Copy link
Contributor Author

Please split this PR into two, one for bumping the dependency and changes to it, and one for adding the attributes.

PR for dependency bump: #125701

Copy link

github-actions bot commented Nov 9, 2024

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@github-actions github-actions bot added the stale label Nov 9, 2024
@emontnemery
Copy link
Contributor

Not stale, waiting for #125701

@github-actions github-actions bot removed the stale label Nov 12, 2024
@madpilot
Copy link
Contributor Author

madpilot commented Dec 1, 2024

Superseded by #131945

@madpilot madpilot closed this Dec 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants