Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark FFmpeg integration as system type #123241

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Mark FFmpeg integration as system type #123241

merged 1 commit into from
Aug 6, 2024

Conversation

frenck
Copy link
Member

@frenck frenck commented Aug 6, 2024

Proposed change

During the beta, ffmpeg came up a couple of times, as it is now listed on the integration dashboard. It is always pulled in via as a dependency.

While there is a YAML configuration available for this integration, it only denotes the location of the ffmpeg binary. It will never create cameras, other integrations will rely on this ffmpeg integration instead.

Therefore, it makes more sense (and cause less confusion) to mark this integration a "system" type of integration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@edenhaus edenhaus merged commit c612cf9 into dev Aug 6, 2024
40 checks passed
@edenhaus edenhaus deleted the frenck-2024-0469 branch August 6, 2024 14:04
frenck added a commit that referenced this pull request Aug 6, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants