Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tami4 device name is None #123156

Merged
merged 9 commits into from
Aug 6, 2024
Merged

Fix Tami4 device name is None #123156

merged 9 commits into from
Aug 6, 2024

Conversation

Yehazkel
Copy link
Contributor

@Yehazkel Yehazkel commented Aug 4, 2024

Breaking change

Proposed change

Fix when water bar name is null

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Yehazkel

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

home-assistant bot commented Aug 4, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft August 4, 2024 21:23
@home-assistant
Copy link

home-assistant bot commented Aug 4, 2024

Hey there @Guy293, mind taking a look at this pull request as it has been labeled with an integration (tami4) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tami4 can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tami4 Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

@Guy293 Guy293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Just fix these small things and we're good to go!

homeassistant/components/tami4/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/tami4/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/tami4/config_flow.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft August 5, 2024 08:51
@Yehazkel Yehazkel marked this pull request as ready for review August 5, 2024 08:56
@home-assistant home-assistant bot requested review from Guy293 and edenhaus August 5, 2024 08:56
@edenhaus edenhaus added this to the 2024.8.0 milestone Aug 5, 2024
@home-assistant home-assistant bot marked this pull request as draft August 5, 2024 09:00
@edenhaus edenhaus changed the title Fix water bar name is null Fix Tami4 device name is None Aug 5, 2024
@Yehazkel Yehazkel marked this pull request as ready for review August 6, 2024 14:05
@home-assistant home-assistant bot requested a review from edenhaus August 6, 2024 14:05
@home-assistant home-assistant bot marked this pull request as draft August 6, 2024 14:08
@edenhaus edenhaus marked this pull request as ready for review August 6, 2024 14:19
@home-assistant home-assistant bot requested a review from edenhaus August 6, 2024 14:19
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Yehazkel 👍

@edenhaus edenhaus merged commit 2000db5 into home-assistant:dev Aug 6, 2024
26 checks passed
frenck pushed a commit that referenced this pull request Aug 6, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tami4 integration - configuration error
4 participants