Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aiohttp 2.3.10 / yarl 1.1.0 #12244

Merged
merged 5 commits into from
Feb 9, 2018
Merged

Update aiohttp 2.3.10 / yarl 1.1.0 #12244

merged 5 commits into from
Feb 9, 2018

Conversation

pvizeli
Copy link
Member

@pvizeli pvizeli commented Feb 8, 2018

@pvizeli pvizeli requested a review from a team as a code owner February 8, 2018 13:04
@Danielhiversen
Copy link
Member

#11660

@pvizeli
Copy link
Member Author

pvizeli commented Feb 8, 2018

That is now fix. There are some bugs around websocket, GET requests they should be fix.

@pvizeli pvizeli closed this Feb 8, 2018
@pvizeli pvizeli deleted the aiohttp branch February 8, 2018 15:01
@balloob
Copy link
Member

balloob commented Feb 8, 2018

Why did you close it?

@pvizeli pvizeli restored the aiohttp branch February 8, 2018 22:21
@pvizeli pvizeli reopened this Feb 8, 2018
@pvizeli
Copy link
Member Author

pvizeli commented Feb 8, 2018

Because you add a comment to #11660 that you want hold all updates until aiohttp 3 is out

@balloob
Copy link
Member

balloob commented Feb 8, 2018

That was for just yarl. Combined with aiohttp I'm fine with it.

@balloob
Copy link
Member

balloob commented Feb 8, 2018

Your tests are failing though, you will need to fix the code.

@pvizeli
Copy link
Member Author

pvizeli commented Feb 8, 2018

Yes, I fix it tomorrow morning after sleeping :)

@pvizeli
Copy link
Member Author

pvizeli commented Feb 9, 2018

@balloob should be fix. I go sleep now :)

@balloob balloob merged commit e4874fd into dev Feb 9, 2018
@balloob balloob deleted the aiohttp branch February 9, 2018 04:57
This was referenced Feb 9, 2018
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants