Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TotalConnect state attribute deprecation warning #122320

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

austinmroczek
Copy link
Contributor

@austinmroczek austinmroczek commented Jul 21, 2024

Breaking change

The TotalConnect integration will remove the following state attributes in 2025.1:

  • triggered_source: instead use panel Binary Sensors 'Police', 'Fire' and 'Carbon Monoxide'
  • ac_loss: instead use panel Binary Sensor 'Power'
  • low_battery: instead use panel Binary Sensor 'Battery'
  • cover_tampered: instead use panel Binary Sensor 'Tamper'
  • triggered_zone: never provided information and will be removed. Instead monitor individual zone Binary Sensors.

Proposed change

This is just a warning that the state attributes are being removed, and that users should move to using the binary sensors instead. A follow up PR is required to actually remove the attributes.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes # n/a
  • This PR is related to issue: n/a
  • Link to documentation pull request: n/a

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed deprecation Indicates a breaking change to happen in the future integration: totalconnect small-pr PRs with less than 30 lines. by-code-owner Quality Scale: No score labels Jul 21, 2024
@joostlek
Copy link
Member

Can we move it to the attr declaration?

@joostlek
Copy link
Member

And it just can be a small "State attributes can be removed in 2025.2"

@austinmroczek austinmroczek marked this pull request as ready for review July 23, 2024 03:26
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 23, 2024
@joostlek joostlek merged commit 142469b into home-assistant:dev Aug 15, 2024
22 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
by-code-owner cla-signed deprecation Indicates a breaking change to happen in the future integration: totalconnect Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants