Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure states table rebuild still happens if the event_id index was removed #121938

Merged
merged 4 commits into from
Jul 14, 2024
Merged

Ensure states table rebuild still happens if the event_id index was removed #121938

merged 4 commits into from
Jul 14, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jul 14, 2024 •
edited
Loading

Proposed change

If ix_states_event_id index was removed but the foreign key still exists, the states table would not get rebuilt. This should not happen under normal circumstances but can if:

  • The index was removed manually
  • Home Assistant was restarted forcefully in the middle of a previous migration from years ago
  • The system ran out of disk space during a previous migration

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@bdraco
Ensure states table rebuild still happens if the event_id index was r…
9d25e55 
…emoved

If ix_states_event_id was removed by the foreign key still
exists, the states table would not get rebuilt. This should
not happen under normal circumstances and seems to only be
possible if the index was removed manually or Home
Assistant was restarted forcefully in the middle
of a previous migration from years ago.
@bdraco bdraco added this to the 2024.7.3 milestone Jul 14, 2024
@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (recorder) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of recorder can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign recorder Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@bdraco bdraco marked this pull request as ready for review July 14, 2024 14:24
@bdraco bdraco requested a review from a team as a code owner July 14, 2024 14:24
balloob
balloob reviewed Jul 14, 2024
View reviewed changes
tests/components/recorder/test_v32_migration.py
patch("homeassistant.components.recorder.Recorder._post_migrate_entity_ids"),
patch(
"homeassistant.components.recorder.Recorder._cleanup_legacy_states_event_ids"
patch.multiple(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL. Nice.

@balloob balloob merged commit 19d2d02 into dev Jul 14, 2024
40 checks passed
@balloob balloob deleted the no_fk branch July 14, 2024 21:20
@github-actions github-actions bot locked and limited conversation to collaborators Jul 15, 2024
@frenck frenck removed this from the 2024.7.3 milestone Jul 19, 2024
@frenck
Copy link
Member

frenck commented Jul 19, 2024

I had to remove this one from the milestone, as it isn't mergeable into the current release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
bugfix cla-signed core integration: recorder Quality Scale: internal small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
3 participants
@bdraco @frenck @balloob