Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unnecessary logging of turn on/off feature flags in Climate #121387

Merged
merged 1 commit into from
Jul 6, 2024
Merged

Fix unnecessary logging of turn on/off feature flags in Climate #121387

merged 1 commit into from
Jul 6, 2024

Conversation

gjohansson-ST
Copy link
Member

Proposed change

Remove potentially unnecessary logging by bailing out early if the integration implements the feature flags when setup (even if not setting the _enable_turn_on_off_backwards_compatibility flag

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@gjohansson-ST gjohansson-ST requested a review from a team as a code owner July 6, 2024 17:04
@home-assistant
Copy link

home-assistant bot commented Jul 6, 2024

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (climate) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of climate can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign climate Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

frenck
frenck approved these changes Jul 6, 2024
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @gjohansson-ST 👍

../Frenck

@frenck frenck added this to the 2024.7.2 milestone Jul 6, 2024
@frenck frenck merged commit ac8ea83 into dev Jul 6, 2024
40 checks passed
@frenck frenck deleted the climate-turn_off_on-feature-flags-fix branch July 6, 2024 17:32
epenet
epenet reviewed Jul 6, 2024
View reviewed changes
homeassistant/components/climate/__init__.py
@@ -377,6 +377,14 @@ def _report_turn_on_off(feature: str, method: str) -> None:
# Return if integration has migrated already
return

supported_features = self.supported_features
if supported_features & (
ClimateEntityFeature.TURN_ON | ClimateEntityFeature.TURN_ON
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this meant to be on/on or on/off?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch. Will update it!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#121398

@gjohansson-ST gjohansson-ST mentioned this pull request Jul 6, 2024
Merged
20 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@epenet epenet epenet left review comments

@bdraco bdraco bdraco left review comments

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
cherry-picked cla-signed core has-tests integration: climate new-feature Quality Scale: internal small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2024.7.2
Development

Successfully merging this pull request may close these issues.
4 participants
@gjohansson-ST @frenck @bdraco @epenet