Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup unifiprotect entity classes #121184

Merged
merged 31 commits into from
Jul 5, 2024
Merged

Cleanup unifiprotect entity classes #121184

merged 31 commits into from
Jul 5, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jul 4, 2024

Proposed change

Small cleanups to unifiprotect entities classes

Change ProtectModelWithId to ProtectDeviceType since this type is what these actually are.

Reduce some duplicate code for the base entity and is on entities.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco bdraco changed the title Small cleanups to unifiprotect entities classes Cleanup unifiprotect entities classes Jul 4, 2024
@bdraco bdraco changed the title Cleanup unifiprotect entities classes Cleanup unifiprotect entity classes Jul 4, 2024
@bdraco
Copy link
Member Author

bdraco commented Jul 4, 2024

Found in testing: Turning off smoke and CO doesn’t seem to work

doesn't seem to be a regression from this though... will need to dig in more

@bdraco
Copy link
Member Author

bdraco commented Jul 4, 2024

not a new problem. doesn't work in 2024.6.4 either so something with the CO and smoke mappings

@bdraco bdraco marked this pull request as ready for review July 4, 2024 15:17
@bdraco
Copy link
Member Author

bdraco commented Jul 4, 2024

Looks like thats been a bug for a while. Fixed it in uilibs/uiprotect#141

@bdraco
Copy link
Member Author

bdraco commented Jul 4, 2024

#121227

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 4, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bdraco 👍

../Frenck

@frenck frenck merged commit d3f4242 into dev Jul 5, 2024
25 checks passed
@frenck frenck deleted the ufp_dry_2 branch July 5, 2024 07:31
@bdraco
Copy link
Member Author

bdraco commented Jul 5, 2024

Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed integration: unifiprotect Quality Scale: No score smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants