-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup unifiprotect entity classes #121184
Conversation
This reverts commit 0f28fd2.
Found in testing: Turning off smoke and CO doesn’t seem to work doesn't seem to be a regression from this though... will need to dig in more |
not a new problem. doesn't work in 2024.6.4 either so something with the CO and smoke mappings |
Looks like thats been a bug for a while. Fixed it in uilibs/uiprotect#141 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @bdraco 👍
../Frenck
Thank you! |
Proposed change
Small cleanups to unifiprotect entities classes
Change
ProtectModelWithId
toProtectDeviceType
since this type is what these actually are.Reduce some duplicate code for the base entity and is on entities.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: