Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import AsyncGenerator from collections.abc in tests #121019

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Jul 2, 2024

Proposed change

SSIA
cc @cdce8p

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jul 2, 2024

Hey there @joostlek, mind taking a look at this pull request as it has been labeled with an integration (twitch) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of twitch can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign twitch Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant
Copy link

home-assistant bot commented Jul 2, 2024

Hey there @joostlek, mind taking a look at this pull request as it has been labeled with an integration (youtube) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of youtube can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign youtube Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

pylint/plugins/hass_imports.py Outdated Show resolved Hide resolved
@epenet epenet marked this pull request as ready for review July 2, 2024 13:27
@epenet epenet requested review from joostlek and a team as code owners July 2, 2024 13:27
@epenet epenet changed the title Force import of Async/Generator from collections.abc Import of AsyncGenerator from collections.abc in tests Jul 2, 2024
@epenet epenet added the smash Indicator this PR is close to finish for merging or closing label Jul 2, 2024
@epenet epenet changed the title Import of AsyncGenerator from collections.abc in tests Import AsyncGenerator from collections.abc in tests Jul 2, 2024
Copy link
Member

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @epenet !

@epenet epenet merged commit e07bf61 into home-assistant:dev Jul 4, 2024
26 checks passed
@epenet epenet deleted the 20240702-1510 branch July 4, 2024 18:24
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed code-quality has-tests integration: twitch integration: youtube Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants