Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump amberelectric to 1.1.1 #121010

Merged
merged 16 commits into from
Jul 2, 2024
Merged

Conversation

madpilot
Copy link
Contributor

@madpilot madpilot commented Jul 2, 2024

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Changelog: https://github.com/madpilot/amberelectric.py/releases/tag/v1.1.1

TL;DR Added a license classifier.

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@madpilot madpilot force-pushed the bump-pypi-version branch from d83d90a to e614998 Compare July 2, 2024 11:25
@epenet epenet changed the title Bump pypi version Bump amberelectric to 1.1.1 Jul 2, 2024
@epenet
Copy link
Contributor

epenet commented Jul 2, 2024

Please edit your PR description to add a link to the changelog, or at minimum a diff between library versions

@epenet epenet marked this pull request as draft July 2, 2024 11:38
@madpilot
Copy link
Contributor Author

madpilot commented Jul 2, 2024

Please edit your PR description to add a link to the changelog, or at minimum a diff between library versions

Done

Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@madpilot madpilot marked this pull request as ready for review July 2, 2024 11:50
@TheJulianJES TheJulianJES merged commit ba7e45e into home-assistant:dev Jul 2, 2024
39 checks passed
@MartinHjelmare
Copy link
Member

Next time, please start with a fresh branch. A PR should not contain old commits from previous work.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants