Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add set_profile service for Vallox integration #120225
Add set_profile service for Vallox integration #120225
Changes from all commits
02ff9d6
3cee7bd
a5408eb
6ea2d4c
a6b6ed7
dc89364
aa178fc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 213 in homeassistant/components/vallox/__init__.py
Codecov / codecov/patch
homeassistant/components/vallox/__init__.py#L212-L213
Check warning on line 216 in homeassistant/components/vallox/__init__.py
Codecov / codecov/patch
homeassistant/components/vallox/__init__.py#L216
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume the true false is something that is for vallox?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just imitated the other code in the vallox module, maybe someone else can answer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, not 100% sure but might just be a leftover from #56966.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should avoid if statements in test code