-
-
Notifications
You must be signed in to change notification settings - Fork 32k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the Select platform in Matter #119769
Add support for the Select platform in Matter #119769
Conversation
Hey there @home-assistant/matter, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
As discussed on email I want to revisit if we can generalize this more into a reusable component for other attributes as well. |
I think I finally understand what you meant by making this more Generic. Looking through the Application Cluster Specification, the following clusters are very similar:
I think the code could be made generic to handle all of these. There is a second application of the Select platform that I had thought about - selecting from ENUM values for writable attributes. I don't think it would be easy to add that into this package since that would work quite differently - that's probably a separate set of classes. |
I will have a look at this later to see if we can adjust it to a more generic way, considering the other select-alike clusters in the Matter spec. |
feature-wise this one is complete now - all that is left is tests, will get to that tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my side this is OK but could use another pair of eyes, due to the fact I refactored this PR on behalf of @jvmahon
Thanks for all the help in improving and finalizing the code for this PR! |
Proposed change
Note: the ModeSelect cluster is used in Inovelli dimmer device and code has been tested with that device to confirm operation
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: