Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the Select platform in Matter #119769

Merged
merged 8 commits into from
Jul 4, 2024
Merged

Add support for the Select platform in Matter #119769

merged 8 commits into from
Jul 4, 2024

Conversation

jvmahon
Copy link
Contributor

@jvmahon jvmahon commented Jun 16, 2024

Proposed change

  • Adds base support for the select platform in Matter
  • Adds support for the Matter ModeSelect Cluster

Note: the ModeSelect cluster is used in Inovelli dimmer device and code has been tested with that device to confirm operation

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/matter, mind taking a look at this pull request as it has been labeled with an integration (matter) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of matter can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign matter Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@MartinHjelmare MartinHjelmare changed the title Modeselect cluster support Add Matter Modeselect cluster support Jun 16, 2024
@marcelveldt
Copy link
Member

As discussed on email I want to revisit if we can generalize this more into a reusable component for other attributes as well.
So my preference would be that we have a generic select platform and entity model and a discovery schema per attribute.

@marcelveldt marcelveldt marked this pull request as draft June 16, 2024 21:39
@jvmahon
Copy link
Contributor Author

jvmahon commented Jun 17, 2024

As discussed on email I want to revisit if we can generalize this more into a reusable component for other attributes as well.
So my preference would be that we have a generic select platform and entity model and a discovery schema per attribute.

I think I finally understand what you meant by making this more Generic.

Looking through the Application Cluster Specification, the following clusters are very similar:

  1. ModeSelect
  2. ModeBaseCluster (and derived cluster Dishwasher Mode Cluster, RVC Run Mode Cluster, RVC Clean Mode Cluster, Laundry Washer Mode Cluster, Refrigerator And Temperature Controlled Cabinet Mode Cluster, Microwave Oven Mode Cluster, Energy EVSE Mode Cluster, etc.)

I think the code could be made generic to handle all of these.

There is a second application of the Select platform that I had thought about - selecting from ENUM values for writable attributes. I don't think it would be easy to add that into this package since that would work quite differently - that's probably a separate set of classes.

@marcelveldt marcelveldt changed the title Add Matter Modeselect cluster support Add support for the Select platform in Matter Jun 21, 2024
@marcelveldt
Copy link
Member

I will have a look at this later to see if we can adjust it to a more generic way, considering the other select-alike clusters in the Matter spec.

@marcelveldt
Copy link
Member

feature-wise this one is complete now - all that is left is tests, will get to that tomorrow

@marcelveldt marcelveldt marked this pull request as ready for review July 4, 2024 15:52
Copy link
Member

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my side this is OK but could use another pair of eyes, due to the fact I refactored this PR on behalf of @jvmahon

@balloob balloob merged commit d5135d4 into home-assistant:dev Jul 4, 2024
25 checks passed
@jvmahon
Copy link
Contributor Author

jvmahon commented Jul 4, 2024

Thanks for all the help in improving and finalizing the code for this PR!

@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2024
@jvmahon jvmahon deleted the modeselect-cluster-support branch July 6, 2024 21:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants