Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump uiprotect to v1.0.1 #119436

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Bump uiprotect to v1.0.1 #119436

merged 1 commit into from
Jun 11, 2024

Conversation

ep1cman
Copy link
Contributor

@ep1cman ep1cman commented Jun 11, 2024

Proposed change

Bump uiprotect version to 1.0.1

Release Notes: https://github.com/uilibs/uiprotect/releases/tag/v1.0.1
Change Log: https://github.com/uilibs/uiprotect/blob/main/CHANGELOG.md
Diff: uilibs/uiprotect@v1.0.0...v1.0.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ep1cman

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft June 11, 2024 22:16
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@ep1cman ep1cman marked this pull request as ready for review June 11, 2024 22:18
@home-assistant home-assistant bot dismissed their stale review June 11, 2024 22:18

Stale

@bdraco
Copy link
Member

bdraco commented Jun 11, 2024

Thanks

There is one more place to update

"requirements": ["uiprotect==1.0.0", "unifi-discovery==1.1.8"],

Also for dep bumps, we ask for one or more of the following in the opening text:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.
    This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

@TheJulianJES

This comment was marked as duplicate.

@ep1cman
Copy link
Contributor Author

ep1cman commented Jun 11, 2024

I have hopefully addressed the comments

@bdraco
Copy link
Member

bdraco commented Jun 11, 2024

Thanks. It looks like the diff link is backwards. Feel free to drop it or fix it as the rest is enough to approve

@bdraco
Copy link
Member

bdraco commented Jun 11, 2024

uilibs/uiprotect@v1.0.0...v1.0.1 would work as well

@bdraco bdraco merged commit 3541764 into home-assistant:dev Jun 11, 2024
38 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants