Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve workday test coverage #119259

Merged
merged 8 commits into from
Jun 10, 2024
Merged

Improve workday test coverage #119259

merged 8 commits into from
Jun 10, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jun 10, 2024

Proposed change

I had started by adding more tests to than fix the breakage reported in #119253, but this was already fixed in #119148 so I couldn't get the tests to fail. As soon as I revert to 2024.6.0, the tests fail spectacularly so we know the issue is fixed in dev.

I'm going to move forward the additional coverage to make sure it doesn't break again in the future.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @fabaff, @gjohansson-ST, mind taking a look at this pull request as it has been labeled with an integration (workday) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of workday can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign workday Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@bdraco
Copy link
Member Author

bdraco commented Jun 10, 2024

I think this is the problem, but the test passes before the change as well, so maybe not

@bdraco
Copy link
Member Author

bdraco commented Jun 10, 2024

This doesn't seem to be the problem because we ignore the result from the callback

@bdraco bdraco closed this Jun 10, 2024
@bdraco bdraco removed this from the 2024.6.2 milestone Jun 10, 2024
@bdraco bdraco reopened this Jun 10, 2024
@bdraco bdraco changed the title Fix workday always calculating time in UTC Improve workday test coverage Jun 10, 2024
@bdraco bdraco added this to the 2024.6.2 milestone Jun 10, 2024
@bdraco bdraco marked this pull request as ready for review June 10, 2024 15:49
@bdraco bdraco requested a review from fabaff as a code owner June 10, 2024 15:49
@bdraco bdraco requested a review from gjohansson-ST as a code owner June 10, 2024 15:49
@frenck frenck merged commit 6127430 into dev Jun 10, 2024
24 checks passed
@frenck frenck deleted the workday_time_zone branch June 10, 2024 18:26
frenck pushed a commit that referenced this pull request Jun 11, 2024
@frenck frenck mentioned this pull request Jun 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants