Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes crashes when receiving malformed decoded payloads #119216

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

angelnu
Copy link
Contributor

@angelnu angelnu commented Jun 9, 2024

Proposed change

Update client to v1.0.0 which does 2 things:

Dependency release page: https://github.com/angelnu/thethingsnetwork_python_client/releases/tag/v1.0.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@angelnu angelnu marked this pull request as ready for review June 9, 2024 16:38
@angelnu
Copy link
Contributor Author

angelnu commented Jun 9, 2024

Ruff error unrelated to this PR -> ready to merge.

This would be a good candidate for the next fix release as it fixes constant reboots of the integration as reported by 2 users.

@frenck frenck changed the title [thethingnetwork] Update ttn_client to v1.0.0 Update ttn_client to v1.0.0 Jun 9, 2024
@angelnu angelnu changed the title Update ttn_client to v1.0.0 Fixes crashes when receiving malformed decoded payloads Jun 9, 2024
@jpbede jpbede added this to the 2024.6.2 milestone Jun 9, 2024
jpbede
jpbede previously requested changes Jun 9, 2024
Copy link
Member

@jpbede jpbede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.

This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Thanks already! 👍

@home-assistant home-assistant bot marked this pull request as draft June 9, 2024 21:01
@home-assistant
Copy link

home-assistant bot commented Jun 9, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@angelnu angelnu marked this pull request as ready for review June 10, 2024 00:31
@home-assistant home-assistant bot requested a review from jpbede June 10, 2024 00:31
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @angelnu 👍

../Frenck

@frenck frenck dismissed jpbede’s stale review June 10, 2024 06:41

Comment addressed

@frenck frenck merged commit 731df89 into home-assistant:dev Jun 10, 2024
38 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[thethingsnetwork] Error after switching to the new integration
4 participants