Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove myself as codeowner for unifiprotect #118824

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Remove myself as codeowner for unifiprotect #118824

merged 1 commit into from
Jun 4, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jun 4, 2024

Proposed change

Users are reaching out to me out of band (and a bit too invasively for my taste) for help with this integration.

As I do not have the bandwidth to be the primary code owner, remove myself. As there are no codeowners remaining, the integration no longer meets the requirements for platinum.

see #117100 (comment). I am happy to add myself back once a primary code owner is found.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Users are reaching out to me out of band (and a bit too invasively for
my taste) for help with this integration.

As I do not have the bandwidth to be the primary code owner, remove
myself.

see #117100 (comment)
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad to see that happening :(

@bdraco
Copy link
Member Author

bdraco commented Jun 4, 2024

Sad to see that happening :(

myself as well. Sad that we ended up here.

@bdraco bdraco merged commit c8e7298 into dev Jun 4, 2024
25 checks passed
@bdraco bdraco deleted the remove_ufp branch June 4, 2024 18:21
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2024
@frenck frenck added this to the 2024.6.2 milestone Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants