Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gemini-1.5-flash-latest in google_generative_ai_conversation.generate_content #118594

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

tronikos
Copy link
Member

@tronikos tronikos commented Jun 1, 2024

Breaking change

Proposed change

The google_generative_ai_conversation.generate_content couldn't be tied to a config entry earlier because it had to use the specific vision model when an image was passed. Now all the 1.5 are multimodal. Switch to using the default gemini-1.5-flash-latest. The docs already mention custom prompt and model settings don't apply to this service. A later PR could tie this to a config entry but that would be a breaking change. Better to wait until we figure out a generic way to handle multimodal across the different integrations though.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@tronikos
Copy link
Member Author

tronikos commented Jun 1, 2024

Can you please include this to the upcoming release? It would be better for paying users to use one model because I think you are getting charged per model per million tokens https://ai.google.dev/pricing

@allenporter allenporter merged commit a461214 into home-assistant:dev Jun 1, 2024
24 checks passed
@allenporter allenporter added this to the 2024.6.0 milestone Jun 1, 2024
@tronikos tronikos deleted the google_ai_vision branch June 1, 2024 05:11
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants