Avoid future exception during setup of Synology DSM

[mib1185]

Proposed change

SSIA

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes 2024.5.2 lots of errors in log when synology is off #116949
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @hacf-fr, @Quentame, mind taking a look at this pull request as it has been labeled with an integration (synology_dsm) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of synology_dsm can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign synology_dsm Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

[bdraco]

If we don't resolve the future, I'm pretty sure every other coordinator will wait forever on the future if its also trying to relogin

[mib1185]

valid point, but i think we should not finished it with an exception, since during setup there will be no later task to wait for the future and consume the exception - those we get Error doing job: Future exception was never retrieved during integrations setup as long as the NAS is down.
Maybe we should just finish the future with done() during setup phase?

[bdraco]

We can set it an than clear the flag instead so it doesn't raise when its gced

example

core/homeassistant/setup.py

Line 181 in 32b51b8

with contextlib.suppress(BaseException):

[mib1185]

uhhh great 👍 was looking for such a solution, but didn't find it 🙈

[bdraco]

I think we should always suppress it since unless there is another execution at the same time it will also be un-retrieved. We should add a comment about why. It's the same reason as I linked above

[mib1185]

you mean this way 0854a0f ?