Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instruct LLM to not pass a list to the domain #118451

Merged
merged 1 commit into from
May 30, 2024

Conversation

tronikos
Copy link
Member

Breaking change

Proposed change

Instruct LLM to not pass a list to the domain. This is an earlier revision of #118443. Instructing it to pass a single domain is only working on Gemini 1.5 flash not Gemini 1.5 pro. Now both of them work correctly and don't pass a list to the domain.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@tronikos tronikos requested a review from a team as a code owner May 30, 2024 03:57
@home-assistant home-assistant bot added bugfix cla-signed core small-pr PRs with less than 30 lines. labels May 30, 2024
@balloob balloob added this to the 2024.6.0 milestone May 30, 2024
@frenck frenck merged commit 4893faa into home-assistant:dev May 30, 2024
33 of 34 checks passed
@tronikos tronikos deleted the llm_prompt_domain branch May 30, 2024 18:34
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants