Fix OpenWeatherMap migration

[freekode]

Breaking change

Fix OpenWeatherMap V3 migration. Migrate all values to config_entry.data.

Proposed change

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes OpenWeatherMap Unsupported API version onecall_daily #118419
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @fabaff, @nzapponi, mind taking a look at this pull request as it has been labeled with an integration (openweathermap) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of openweathermap can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign openweathermap Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

[freekode]

@bdraco I hope this will be enough

[freekode]

I will be away till the end of the week. PR can be edited by maintainers, just in case.

[bdraco]

Still seeing

2024-05-29 10:56:58.978 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry OpenWeatherMap for openweathermap
Traceback (most recent call last):
  File "/Users/bdraco/home-assistant/homeassistant/config_entries.py", line 594, in async_setup
    result = await component.async_setup_entry(hass, self)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/bdraco/home-assistant/homeassistant/components/openweathermap/__init__.py", line 47, in async_setup_entry
    language = _get_config_value(entry, CONF_LANGUAGE)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/bdraco/home-assistant/homeassistant/components/openweathermap/__init__.py", line 105, in _get_config_value
    return config_entry.options[key]
           ~~~~~~~~~~~~~~~~~~~~^^^^^
KeyError: 'language'

[bdraco]

let me reset and try again as I might have had a bad test

[bdraco]

I think _get_config_value can be dropped as well now

[bdraco]

trying again with

        "data": {
          "api_key": "xxx",
          "name": "OpenWeatherMap",
          "latitude": 0.0,
          "longitude": -0.0,
          "mode": "onecall_daily",
          "language": "en"
        },
        "options": {
          "mode": "onecall_daily",
          "language": "es"
        },

[bdraco]

It solves the issue.
_get_config_value can be cleaned up in a future PR

[ChristophCaina]

should this also fix #118437 ?