Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify async_track_time_interval implementation #117956

Merged
merged 4 commits into from
May 23, 2024
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 23, 2024

Proposed change

  • use loop.call_at directly since we always have a HassJob
  • reduce duplicate code

When reviewing #117879, I realized we can reduce this down a bit more

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

- use loop.call_at directly since we always have a HassJob
- reduce duplicate code
bdraco added 3 commits May 22, 2024 16:47
- use loop.call_at directly
- reduce duplicate code
- use loop.call_at directly
- reduce duplicate code
hass = self.hass
loop = hass.loop
self._timer_handle = loop.call_at(
loop.time() + self.seconds, self._interval_listener, self._track_job
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its kinda strange to still pass the job here even though we don't use it anymore, but if we take it out it won't be cancelled automatically at shutdown because the we need the cancel_on_shutdown logic.

@bdraco
Copy link
Member Author

bdraco commented May 23, 2024

Working as expected. Avoids a second async_run_hass_job call every time it fires as well now

Screenshot 2024-05-22 at 9 55 52 PM

@bdraco bdraco marked this pull request as ready for review May 23, 2024 07:56
@bdraco bdraco requested a review from a team as a code owner May 23, 2024 07:56
@bdraco bdraco merged commit 6c6a5f4 into dev May 23, 2024
38 checks passed
@bdraco bdraco deleted the track_time_interval_simp branch May 23, 2024 07:56
@bdraco
Copy link
Member Author

bdraco commented May 23, 2024

thanks!

@bdraco bdraco restored the track_time_interval_simp branch May 23, 2024 20:14
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2024
@bdraco bdraco deleted the track_time_interval_simp branch June 7, 2024 00:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants