Add option to login with username/email and password in Habitica integration #117622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
code-quality
has-tests
integration: habitica
labels
|
Hey there @asmfreak, @leikoilja, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
edenhaus
previously requested changes
May 28, 2024
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
tr4nt0r
force-pushed
the
habitica_config_flow
branch
from
3f4e0b7 to
c5e6b26
Compare
frenck
added
the
smash
tr4nt0r
changed the title
tr4nt0r
force-pushed
the
habitica_config_flow
branch
from
2ac0da8 to
720cb13
Compare
tr4nt0r
force-pushed
the
habitica_config_flow
branch
3 times, most recently
from
634fc2f to
aeae1be
Compare
8 tasks
joostlek
requested changes
Aug 21, 2024
| "api_user": "Habitica’s API user ID", | ||
| "api_key": "[%key:common::config_flow::data::api_key%]" | ||
| "api_user": "User ID", | ||
| "api_key": "API Token", |
There was a problem hiding this comment.
we have a common key for this right?
There was a problem hiding this comment.
I changed this because that is how it is called by Habitica.
tr4nt0r
force-pushed
the
habitica_config_flow
branch
from
65d9d0a to
63a33c2
Compare
joostlek
approved these changes
Aug 30, 2024
tr4nt0r
force-pushed
the
habitica_config_flow
branch
from
63a33c2 to
b086010
Compare
joostlek
approved these changes
Aug 30, 2024
joostlek
approved these changes
Aug 30, 2024
synesthesiam
pushed a commit
that referenced
this pull request
Aug 30, 2024
…gration (#117622) * add login/password authentication * add advanced config flow * remove unused exception classes, fix errors * update username in init * update tests * update strings * combine steps with menu * remove username from entry * update tests * Revert "update tests" This reverts commit 6ac8ad6. * Revert "remove username from entry" This reverts commit d9323fb. * small changes * remove pylint broad-excep * run habitipy init in executor * Add text selectors * changes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopened as new PR because I messed up when resolving merge conflicts.
Proposed change
The Config Flow for setting up the Habitica integration is now a lot more user-friendly. Users can now user their normal username/e-mail and password combination they also use to login to Habitica, instead having to handle with their User ID and API Token. The Config Flow then stores the User ID and API Token which are returned in the JSON response of the login endpoint.
Because Habitica is open source, users could want to connect to a different instance than the official Habitica, even to a self-hosted one. Therefore users can choose between "Login to Habitica" and an "Advanced Configuration". The Advanced Configuration still offers the same options as before, like using User ID and API Token and the URL to point to a different instance. Just an option to disable SSL verification was added, in case it is an instance with a self-signed certificate.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: