Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tibber sensors state class #117085

Merged
merged 3 commits into from
May 17, 2024
Merged

Fix Tibber sensors state class #117085

merged 3 commits into from
May 17, 2024

Conversation

basbruss
Copy link
Contributor

@basbruss basbruss commented May 8, 2024

Breaking change

Proposed change

This changes the state classes for two sensors since they have a reset cycle and should according to the docs have state class Total_Increasing

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented May 8, 2024

Hey there @Danielhiversen, mind taking a look at this pull request as it has been labeled with an integration (tibber) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tibber can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tibber Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@TheJulianJES TheJulianJES changed the title Add correct state classes Fix Tibber sensors state class May 8, 2024
@hagen93
Copy link

hagen93 commented May 9, 2024

I was just looking into this as I'm having issues with my Energy dashboard and Tibber too. If I understand it correctly the same issue also applies to accumulated_cost and accumulated_reward too, correct?

@basbruss
Copy link
Contributor Author

basbruss commented May 9, 2024

@hagen93 for accumulated_cost I am not sure since it can decrease within a cycle due to energy usage associated with negative energy prices. So Total with a last reset attribute seems more appropriate to me. Maybe a core team member can clarify it?

@Danielhiversen
Copy link
Member

Correct, accumulated_cost and accumulated_reward are not always increasing.

@cgarwood cgarwood merged commit 658c1f3 into home-assistant:dev May 17, 2024
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tibber -> entity accumulated costs not working with energy dashboard
5 participants