-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test MQTT subscription is completed when birth message is sent #116476
Conversation
Hey there @emontnemery, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
await hass.async_block_till_done() | ||
hass.bus.async_fire(EVENT_HOMEASSISTANT_STARTED) | ||
# We wait until we receive a birth message | ||
await asyncio.wait_for(birth.wait(), 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
asyncio.timeout
is generally preferred over asyncio.wait_for
since its more efficient
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't generally matter anymore though since asyncio.wait_for is effectively a wrapper around asyncio.timeout in py3.12+
Tagging this to make it easier on whoever is doing the release by avoiding future conflicts in case we have to backport any more mqtt fixes to 2024.5.x |
Thanks @jbouwh |
Proposed change
Add test MQTT subscription is completed when birth message is sent
As an addition to: #116471
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: