Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread: Add more Thread vendor to brand mappings #115888

Merged
merged 6 commits into from
May 28, 2024

Conversation

Poshy163
Copy link
Contributor

Breaking change

Proposed change

Add additional vendor to brand mappings for known Thread border router vendors.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@Poshy163 Poshy163 requested a review from a team as a code owner April 20, 2024 13:30
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Poshy163

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft April 20, 2024 13:30
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (thread) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of thread can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign thread Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@Poshy163 Poshy163 marked this pull request as ready for review April 20, 2024 13:32
@balloob
Copy link
Member

balloob commented Apr 25, 2024

Do you have a source to show these are used?

@Poshy163
Copy link
Contributor Author

All of of the smart things IoT gateways are under samsung as the manufacturer (smartthings station and more in the pipeline), and the aquara has the newly released M3 hub.

This only came up as some of the people in the thread channel had noticed some of these newer vendors have no images for the new border routers. was verified the vendors with the mdns data under (_meshcop._udp.local.) and under (vn) for the vendor.

Copy link
Member

@agners agners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked actual implementation, do these vendors use this exact string in their mDNS announcements?

But generally, LGTM.

@Poshy163
Copy link
Contributor Author

Poshy163 commented May 6, 2024

Yeah, peer checked with people from the thread channel on discord, here and here

Seems this is just gonna be on big wack-a-mole to get vendors added as they come out with new devices.

@agners
Copy link
Member

agners commented May 7, 2024

Yeah, peer checked with people from the thread channel ondiscord, here and here

Perfect, thanks!

From what I can tell the aqara brand icon is currently missing in the brands repository, so I afaik this won't work as is. 🤔

Seems this is just gonna be on big wack-a-mole to get vendors added as they come out with new devices.

Yeah 😢

@Poshy163
Copy link
Contributor Author

Poshy163 commented May 8, 2024

From what I can tell the aqara brand icon is currently missing

Yeah, there is both aqara_gateway and aqara_bridge, so have updated that.

Also seen a few people are getting their hands on the GL.Net thread routers, so might have to make a pull to the brands repo adding them in as i don't see them in under as of their aliases

@edenhaus edenhaus merged commit 90500c4 into home-assistant:dev May 28, 2024
19 of 20 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants