-
-
Notifications
You must be signed in to change notification settings - Fork 32k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thread: Add more Thread vendor to brand mappings #115888
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Do you have a source to show these are used? |
All of of the smart things IoT gateways are under samsung as the manufacturer (smartthings station and more in the pipeline), and the aquara has the newly released M3 hub. This only came up as some of the people in the thread channel had noticed some of these newer vendors have no images for the new border routers. was verified the vendors with the mdns data under (_meshcop._udp.local.) and under (vn) for the vendor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you checked actual implementation, do these vendors use this exact string in their mDNS announcements?
But generally, LGTM.
Perfect, thanks! From what I can tell the
Yeah 😢 |
Yeah, there is both Also seen a few people are getting their hands on the GL.Net thread routers, so might have to make a pull to the brands repo adding them in as i don't see them in under as of their aliases |
Breaking change
Proposed change
Add additional vendor to brand mappings for known Thread border router vendors.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: