-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Risco exception logging #115232
Merged
Merged
Improve Risco exception logging #115232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
code-quality
integration: risco
small-pr
PRs with less than 30 lines.
by-code-owner
Quality Scale: platinum
labels
Apr 8, 2024
OnFreund
commented
Apr 8, 2024
joostlek
reviewed
Apr 8, 2024
bdraco
reviewed
Apr 10, 2024
bdraco
reviewed
Apr 10, 2024
bdraco
reviewed
Apr 10, 2024
bdraco
requested changes
Apr 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please let the logger format this instead
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
OnFreund
force-pushed
the
risco_exceptions
branch
from
April 10, 2024 16:01
4290b46
to
a2da236
Compare
bdraco
approved these changes
Apr 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
by-code-owner
cherry-picked
cla-signed
code-quality
integration: risco
Quality Scale: platinum
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Exception from pyrisco are sent as Exception objects rather than raised. This PR makes sure the error and stack trace are logged, rather than just the error. This should assist in troubleshooting Risco issues.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: