Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable maximum concurrency in Risco local #115226

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

OnFreund
Copy link
Contributor

@OnFreund OnFreund commented Apr 8, 2024

Proposed change

Add a config flow option to the Risco integration to control the maximum number of concurrent requests to the panel.
Older panels have a hard time with high concurrency (and recent changes to HA startups also seem to require a lower value on newer panels), but setting it low will increase the amount of time required to get all zones and thus initialize the integration.
By making this configurable, advanced users can change this based on their panel and number of zones, and it will also serve as a useful troubleshooting step with other users.

Apart from #115118 this might also resolve #114049 and #114830.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@OnFreund OnFreund force-pushed the risco_concurrency branch from e0e8696 to 418239f Compare April 8, 2024 17:33
@joostlek joostlek added this to the 2024.4.3 milestone Apr 8, 2024
@joostlek
Copy link
Member

joostlek commented Apr 9, 2024

I think its a good idea to mention the existence of these options in the documentation

@joostlek joostlek merged commit a852a38 into home-assistant:dev Apr 9, 2024
19 of 20 checks passed
@OnFreund OnFreund deleted the risco_concurrency branch April 9, 2024 08:02
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants