Make hass-nabucasa a core requirement #112623
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Make hass-nabucasa a core requirement to ensure the correct version is installed
Background:
We import hass-nabucasa directly from the http integration as well as from the network helper:
core/homeassistant/helpers/network.py
Line 317 in dfae64a
core/homeassistant/components/http/forwarded.py
Lines 82 to 84 in dfae64a
If either of these imports happen before we've processed the requirements of the
cloud
integration,hass_nabucasa
is already imported before we upgrade it with help ofpip
, which causes the import errors seen in the linked PR.An alternative solution would be to remove the imports of hass-nabucasa from the network helper and the http integration
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: