Add rainbird request debouncer and immediately update entity switch state

[allenporter]

Proposed change

Add rainbird request debouncer and immediately update entity switch state. This avoids a problem where when setting a switch it goes back to the old state after a few seconds because the rainbird device state takes a moment to actually reflect the new state.

This adds a request debouncer with a cooldown of 5 seconds so that it will request the new state with a few seconds for it to be updated.

The existing tests still pass without modification, and this was tested manually against a live device.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes Rainbird: long wait for switch status change #102498
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @konikvranik, mind taking a look at this pull request as it has been labeled with an integration (rainbird) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of rainbird can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign rainbird Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

[jellyneck84]

@allenporter thanks for your work
@balloob when will this change be available for testing? It will show up as an available update in HA, right?

[allenporter]

@allenporter thanks for your work
@balloob when will this change be available for testing? It will show up as an available update in HA, right?

It's not merged yet. Once merged it will be in a release. We haven't tagged this for a specific patch release so it will probably be in the 2024.4 release.

[jellyneck84]

@allenporter thanks for your work
@balloob when will this change be available for testing? It will show up as an available update in HA, right?

It's not merged yet. Once merged it will be in a release. We haven't tagged this for a specific patch release so it will probably be in the 2024.4 release.

Thanks for explaining. I assume there is no way to test it before as a "beta" ?

[allenporter]

@allenporter thanks for your work
@balloob when will this change be available for testing? It will show up as an available update in HA, right?

It's not merged yet. Once merged it will be in a release. We haven't tagged this for a specific patch release so it will probably be in the 2024.4 release.

Thanks for explaining. I assume there is no way to test it before as a "beta" ?

There are nightly dev releases, then betas are cut a week before the prod release for early community testing.

[edenhaus]

Thanks @allenporter 👍

[edenhaus]

As this is a bugfix, is it fine to ship it with the next release, or are there concerns about not doing it? @allenporter

[allenporter]

As this is a bugfix, is it fine to ship it with the next release, or are there concerns about not doing it? @allenporter

I'm just being conservative... This integration has had these problems for a couple years.

There are 2 changes that probably need to go in given a merge conflict, but they are both stability fixes. I assume the current beta cycle is slowing down, but I guess we could put both changes in and make this round.

[jellyneck84]

Glad that we have maybe a fix for this after years ;-) Otherwise it's not stable for a real automation for me :-) I already signed up to beta and waiting to test it ;-) Am Mo., 4. März 2024 um 15:07 Uhr schrieb Allen Porter < ***@***.***>:

…

As this is a bugfix, is it fine to ship it with the next release, or are there concerns about not doing it? @allenporter <https://github.com/allenporter> I'm just being conservative... This integration has had these problems for a couple years. There are 2 changes that probably need to go in given a merge conflict, but they are both stability fixes. I assume the current beta cycle is slowing down, but I guess we could put both changes in and make this round. — Reply to this email directly, view it on GitHub <#112152 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQOAZJ7HHGBB5VHKJCWFOULYWR5ZLAVCNFSM6AAAAABEEPDTMWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZWGY3DCMBQHA> . You are receiving this because you commented.Message ID: ***@***.***>

[allenporter]

The other change makes a connection pool change, and while I tested manually maybe there another side effect I missed...

I broke this integration a couple times before with what I thought was a small change so maybe I just prefer the full test cycle...