Fix circular imports in core integrations #111875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
approved these changes
Feb 29, 2024
|
test failed because cloud took too long to import FAILED tests/test_circular_imports.py::test_circular_imports[cloud] - Failed: Timeout >9.0s |
emontnemery
reviewed
Feb 29, 2024
homeassistant/helpers/http.py
Outdated
There was a problem hiding this comment.
Why is this helper created in a PR which is preventing circular imports?
There was a problem hiding this comment.
Its moving the code that is being imported circularly to another module
balloob
approved these changes
Mar 1, 2024
balloob
approved these changes
Mar 1, 2024
balloob
pushed a commit
that referenced
this pull request
Mar 1, 2024
* Fix circular imports in core integrations * fix circular import * fix more circular imports * fix more circular imports * fix more circular imports * fix more circular imports * fix more circular imports * fix more circular imports * fix more circular imports * adjust * fix * increase timeout * remove unused logger * keep up to date * make sure its reprod
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Fix circular imports in core integrations
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: