-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate old config options for MQTT json light #111676
Conversation
Hey there @emontnemery, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @jbouwh 👍
Breaking change
Support for
brightness
is now assumed formqtt
lights with thejson
schema unless only color modesrgb
,rgbw
orrgbww
are supported.For light which only support color modes
rgb
,rgbw
orrgbww
, thebrightness
option flag can still be set tofalse
if brightness is not supported, in this case brightness support is emulated in Home Assistant by scaling the RGBx-values.For all other color modes except
ColorMode.ONOFF
, it is assumed brightness is supported and thebrightness
attribute will be included in the MQTT payload when thebrightness
attribute is supplied to thelight.turn_on
service.Proposed change
Deprecate the flag settings
color_mode
,color_temp
,hs
,rgb
andxy
for the mqttlight
schema. The optionscolor_temp
,hs
,rgb
andxy
were already removed from the documentation, but the options were not marked deprecated in the schema yet.The
color_mode
flag is not used anymore, and should be removed. Insteadsupported_color_modes
is checked. If it is not set, then thecolor_temp
, hs,
rgband
xy` flags will still be evaluated.Brightness is assumed to be supported by default. For
rgbx
lights that do not support brightnessbrightness
should be explicitly set tofalse
.The deprecated options are planned to be removed with HA Core 2025.3, this is in line with the deprecation grace period on the light entity platform support.
Type of change
Additional information
brightness
andcolor_mode
should be deprecated #110682color_mode
flag, adjustbrightness
description for MQTT json light home-assistant.io#31707Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: