Deprecate hass.components and log warning if used inside custom component
#111508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpbede
changed the title
@bind_hass and log warning if used inside custom component
balloob
reviewed
Feb 26, 2024
home-assistant
bot
added
cla-signed
core
deprecation
jpbede
force-pushed
the
bind-hass-log-on-use
branch
from
ca3dc0a to
afc262f
Compare
5 tasks
jpbede
changed the title
@bind_hass and log warning if used inside custom componenthass.components and log warning if used inside custom component
ludeeus
reviewed
Feb 28, 2024
This was referenced Feb 28, 2024
jpbede
commented
Feb 28, 2024
| report( | ||
| ( | ||
| f"accesses hass.components.{comp_name}." | ||
| " This is deprecated and will stop working in Home Assistant 2024.6, it" |
There was a problem hiding this comment.
Lets make it 6 months (home-assistant/developers.home-assistant#2093 (review))
Suggested change
| " This is deprecated and will stop working in Home Assistant 2024.6, it" | |
| " This is deprecated and will stop working in Home Assistant 2024.9, it" |
There was a problem hiding this comment.
Yikes, yes, thought I've hit "Commit suggestion". Will create a PR.
There was a problem hiding this comment.
Fixed in #111903. Thanks for noticing it.
MartinHjelmare
requested changes
Feb 29, 2024
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
jpbede
force-pushed
the
bind-hass-log-on-use
branch
from
dc54011 to
ad82e69
Compare
balloob
pushed a commit
that referenced
this pull request
Feb 29, 2024
…ponent (#111508) * Deprecate @bind_hass and log error if used inside custom component * Log also when accessing `hass.components` * Log warning only when `hass.components` is used * Change version * Process code review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Deprecate the use of(isn't used that much in custom integrations),@bind_hassdecoratorDeprecate the use of
hass.components. The use within a custom component will issue a warning to the log.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: