ONVIF Camera added Error handling and rtsp authentication. #11129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Dec 13, 2017
| ) | ||
| self._input = stream_uri.Uri.replace( | ||
| 'rtsp://', 'rtsp://{}:{}@'.format(config.get( | ||
| CONF_USERNAME), config.get(CONF_PASSWORD)), 1) |
There was a problem hiding this comment.
continuation line missing indentation or outdented
| _LOGGER.debug("ONVIF Camera Using the following URL for %s: %s", | ||
| self._input = None | ||
| try: | ||
| _LOGGER.debug("Attempting to communicate with ONVIF Camera: %s on port %s", |
There was a problem hiding this comment.
line too long (87 > 79 characters)
Bugfixes for several issues with hass.io and non-venv installations
|
Do I need to do any other changes to this? |
|
I would really appreciate if this PR can be merged in the next days, because I have a PR in the pipe-line since almost 1 month, which is in conflict with that PR. |
9 tasks
Bugfixes for several issues with hass.io and non-venv installations
matt2005
commented
Jan 17, 2018
… dev # Conflicts: # homeassistant/components/camera/onvif.py
9 tasks
Merged
ghost
added
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfixes for several issues with hass.io and non-venv installations
Description:
Added passing of credentials to RTSP stream
Changed from ONVIFService to ONVIFCamera as ONVIFService didn't contain the same error handling.
Changed method to get Stream URL from camera to a more compatible method
Added extra Error handling
Checklist:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests pass