Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move late import of config flows in loader to load time #110688

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Move late import of config flows in loader to load time #110688

merged 2 commits into from
Feb 16, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Feb 15, 2024 •
edited
Loading

Proposed change

There does not seem to be any reason to import the generated flows late (at least not with the current code). Import them at load time with the rest of the generated files

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco
Move late import of config flows in loader to load time
84cd2ad 
There does not seem to be any reason to import the
generated flows late. Import them at load time
with the rest of the generated files
@bdraco bdraco marked this pull request as ready for review February 16, 2024 00:12
@bdraco bdraco requested a review from a team as a code owner February 16, 2024 00:12
MartinHjelmare
MartinHjelmare approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should always add a comment explaining why an import is not top level when we do that.

@MartinHjelmare MartinHjelmare merged commit 37897ee into dev Feb 16, 2024
53 checks passed
@MartinHjelmare MartinHjelmare deleted the flows_import branch February 16, 2024 06:55
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
cla-signed code-quality core small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdraco @MartinHjelmare