Matching duplicate named entities is now an error in Assist #110050
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Targeting entities with the same name or alias is now an error in Assist, resulting in an error like "Sorry, there are multiple devices named overhead light". If the entities are in different areas, they can still be targeted ("turn on overhead light in the bedroom"). This avoids the previous behavior where one of the entities would be targeted, depending on its position in HA's state machine.
This PR also completes the fix for issue: #109868
Type of change
Additional information
name
and anarea
, we do not search for thename
in thearea
, we search thename
globally. #109868Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: