Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow modbus "scale" to be negative. #109965

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

janiversen
Copy link
Member

Breaking change

Proposed change

"scale" is used to scale the value and thus a positive float, however some configurations (mis)use scale to negate the value, by setting scale to -1.

Even though it was not the intended usage, it is a valid and elegant way to negate a value. This PR allows it.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@joostlek
Copy link
Member

joostlek commented Feb 8, 2024

Maybe add a test case to avoid any regression in the future

@joostlek joostlek added this to the 2024.2.1 milestone Feb 8, 2024
@janiversen
Copy link
Member Author

Maybe add a test case to avoid any regression in the future

Good idea, added.

And I updated dev, since it seems another integration is blocking CI.

@janiversen janiversen merged commit 55f1065 into home-assistant:dev Feb 8, 2024
46 of 48 checks passed
@janiversen janiversen deleted the solve_109967 branch February 8, 2024 11:40
frenck pushed a commit that referenced this pull request Feb 9, 2024
@frenck frenck mentioned this pull request Feb 9, 2024
@RacerEdge
Copy link

Hi,
I used this "scale: -1" to convert the input.
Now it doesn't work. :-(
How can I implement this now?

Regards

@janiversen
Copy link
Member Author

It does work ! with 2024.2.1

@RacerEdge
Copy link

oh...sorry.
when will 2024.2.1 released?

i have 24.2.0

@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modbus: Negative scale not allowed since introduction of HA standard number_validator
4 participants