-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow modbus "scale" to be negative. #109965
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
bugfix
cla-signed
integration: modbus
small-pr
PRs with less than 30 lines.
by-code-owner
Quality Scale: gold
labels
Feb 8, 2024
joostlek
approved these changes
Feb 8, 2024
Maybe add a test case to avoid any regression in the future |
Good idea, added. And I updated dev, since it seems another integration is blocking CI. |
joostlek
approved these changes
Feb 8, 2024
janiversen
force-pushed
the
solve_109967
branch
from
February 8, 2024 10:50
49a38b6
to
aa0e433
Compare
frenck
pushed a commit
that referenced
this pull request
Feb 9, 2024
Merged
Hi, Regards |
It does work ! with 2024.2.1 |
oh...sorry. i have 24.2.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bugfix
by-code-owner
cherry-picked
cla-signed
integration: modbus
Quality Scale: gold
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
"scale" is used to scale the value and thus a positive float, however some configurations (mis)use scale to negate the value, by setting scale to -1.
Even though it was not the intended usage, it is a valid and elegant way to negate a value. This PR allows it.
Type of change
Additional information
This PR fixes or closes issue: fixes #
fixes Modbus: Negative scale not allowed since introduction of HA standard number_validator #109957
This PR is related to issue:
Link to documentation pull request:
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: