Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump blebox_uniapi to 2.2.1 #108918

Merged

Conversation

swistakm
Copy link
Contributor

@swistakm swistakm commented Jan 26, 2024

Proposed change

Update blebox_uniapi package version to 2.2.1 (latest). This version incorporates small improvements/fixes to collection of power measurement data of switchBox and switchBoxD devices. Also resolves problem logged regarding power measurements (see #103421).

I'm now official maintainer of blebox_uniapi (pinging @bbx-a and @riokuu to confirm) and will be working on this project for some longer time, so I have added myself to blebox component codeowners.


2.2.1

Changelog:

  • fixed support for power measurement capabilities of switchBox and switchBoxD devices

Release: link
Diff: blebox/blebox_uniapi@v2.2.0...v2.2.1


2.2.2

Changelog:

Release: link
Diff: blebox/blebox_uniapi@v2.2.1...v2.2.2


Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

home-assistant[bot]

This comment was marked as resolved.

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft January 26, 2024 16:28
@home-assistant
Copy link

Hey there @bbx-a, @riokuu, mind taking a look at this pull request as it has been labeled with an integration (blebox) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of blebox can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign blebox Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@swistakm swistakm force-pushed the update/bump-blebox-uniapi-version branch from 8c52121 to af32d6b Compare January 26, 2024 16:33
home-assistant[bot]

This comment was marked as resolved.

@bbx-a
Copy link

bbx-a commented Jan 31, 2024

Hey there @bbx-a, @riokuu, mind taking a look at this pull request as it has been labeled with an integration (blebox) you are listed as a code owner for? Thanks!

The changes look good!

Welcome to the new code owner @swistakm

@swistakm swistakm marked this pull request as ready for review January 31, 2024 09:43
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.

This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Thanks already! 👍

@home-assistant home-assistant bot marked this pull request as draft January 31, 2024 16:03
@swistakm
Copy link
Contributor Author

swistakm commented Feb 7, 2024

Hey @edenhaus. Sorry for delay. Was busy working on other issues over the week. In the meantime we have fixed another minor issue on the blebox_uniapi side and released another patch release. Here is summary of all the changes in chronological order:


2.2.1

Changelog:

  • fixed support for power measurement capabilities of switchBox and switchBoxD devices

Release: link
Diff: blebox/blebox_uniapi@v2.2.0...v2.2.1


2.2.2

Changelog:

Release: link
Diff: blebox/blebox_uniapi@v2.2.1...v2.2.2


We have another small fix to be merged soon (blebox/blebox_uniapi#153) but I think it would be better to update in smaller batches. WDYT?

Last but not least, if you by chance want to test evaluate changes locally but don't have any blebox device at hand: I've built a small simulator for selected devices. It is not complete but I plan to extend it over time. It supports zeroconf (but only on macOS) so homeassistant can discover all simulated devices. It makes much easier to evaluate backward compatibility of historical device variants.

@swistakm
Copy link
Contributor Author

swistakm commented Feb 7, 2024

@swistakm swistakm marked this pull request as ready for review February 27, 2024 21:20
@home-assistant home-assistant bot requested a review from edenhaus February 27, 2024 21:20
@swistakm
Copy link
Contributor Author

@edenhaus I have just noticed that automation marked this PR as draft and I completely missed it.

Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @swistakm 👍
Can be merged if CI is passing

@edenhaus
Copy link
Contributor

@edenhaus I have just noticed that automation marked this PR as draft and I completely missed it.

No need to ping me as the bot already requested a review from me, when you click "Ready for review"

@edenhaus edenhaus changed the title Bump blebox_uniapi to 2.2.1 and update blebox component code owners Bump blebox_uniapi to 2.2.1 Feb 28, 2024
@edenhaus edenhaus merged commit 12b15a9 into home-assistant:dev Feb 28, 2024
53 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lot of errors in logs with Blebox integration
4 participants