Significantly reduce websocket api connection auth phase latency #108564
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
I started looking at the auth phase timings as a result of testing #108428 and noticed initial auth on the websocket connection took about 35-60ms locally.
Since the auth phase has exclusive control over the websocket until
ActiveConnection
is created, we can bypass the queue and send messages right away. This reduces the latency and reconnect time since we do not have to wait for the background processing of the queue to send the auth required/ok messages.Additionally we now only start the queue consumer aka
_writer
if auth is successful since we no longer need it for auth failure cases. This saves some cpu cycles if there are a lot of failed auth attempts (ie brute force attacks).locally its much faster
remote on local network is almost as good
and remote ~4000 miles away with >100ms ping time
On average this saves ~30ms of latency on reconnect/wake
My test install also has aiohttp 3.10.x and jpadilla/pyjwt#940 which also helps improve the performance
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: