-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the Spotify DJ #107268
Merged
Merged
Add support for the Spotify DJ #107268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
bugfix
cla-signed
integration: spotify
small-pr
PRs with less than 30 lines.
labels
Jan 5, 2024
Hey there @frenck, @joostlek, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Add error handling for playlist lookup to ensure it doesn't break current playback state loading
Add exception type to playlist lookup error handling
BTMorton
force-pushed
the
spotify-dj-support
branch
from
January 5, 2024 17:35
f613455
to
2761ad3
Compare
joostlek
requested changes
Jan 5, 2024
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Joost Lekkerkerker <[email protected]>
joostlek
approved these changes
Jan 6, 2024
jmuf
pushed a commit
to jmuf/homeassistant_core
that referenced
this pull request
Jan 6, 2024
* Add support for the Spotify DJ playlist by mocking the playlist response Add error handling for playlist lookup to ensure it doesn't break current playback state loading * Run linters Add exception type to playlist lookup error handling * Fix typo in comment Co-authored-by: Joost Lekkerkerker <[email protected]> --------- Co-authored-by: Joost Lekkerkerker <[email protected]>
jmuf
pushed a commit
to jmuf/homeassistant_core
that referenced
this pull request
Jan 7, 2024
* Add support for the Spotify DJ playlist by mocking the playlist response Add error handling for playlist lookup to ensure it doesn't break current playback state loading * Run linters Add exception type to playlist lookup error handling * Fix typo in comment Co-authored-by: Joost Lekkerkerker <[email protected]> --------- Co-authored-by: Joost Lekkerkerker <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bugfix
cherry-picked
cla-signed
integration: spotify
Quality Scale: silver
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add support for the new Spotify DJ feature by mocking the playlist response. The Spotify Web API currently doesn't support the DJ feature and returns a 404 error when trying to lookup the playlist details. If the context contains the URI for the DJ playlist, instead of performing a playlist lookup, a mock playlist object will be used to provide the minimal set of required playlist data.
I've also added some extra error handling around the playlist lookup to prevent a failing playlist request breaking the current playback state update. This error handling by itself could fix the issue, but I wanted to also have the
media_playlist
property be populated if the DJ URI is detected.I've used this URI as the DJ playlist URI as it seems to be the same in my testing and from other users requesting support on the Spotify Community website:
Spotify Community support requests:
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: