Improve fitbit authentication error handling #106885
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Improve fitbit authentication error code handling by treating a 400 Bad Request as needing reauth since this can happen with credentials get invalidated. Adds test coverage for (1) oauth endpoint token refresh on startup confirming that it it initiates reauth and (2) that normal sensor updates do not trigger this behavior and are still just treated like failures.
Note: This is not a new issue, but an existing issue. This is tagged for the next milestone, but can happen in any upcoming milestone, and is not a release blocker.
Type of change
Additional information
Issue observed on my production instance:
Debug log:
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: