Changed setup of EnergyZero services #106224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
code-quality
has-tests
integration: energyzero
labels
|
Hey there @klaasnicolaas, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
@MartinHjelmare Can you take a look at this setup following your comment: #101374 (comment) |
8 tasks
MartinHjelmare
requested changes
Dec 22, 2023
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Will you be able to get all the changes ready for the January release? |
I'll continue and try to finish it tomorrow. The conclusion was that the entity ID stays as a service parameter, right? |
Co-authored-by: Martin Hjelmare <[email protected]>
|
It remains a service parameter for now |
klaasnicolaas
approved these changes
Dec 31, 2023
frenck
pushed a commit
that referenced
this pull request
Jan 2, 2024
* Changed setup of energyzero services * PR review updates * Dict access instead of get Co-authored-by: Martin Hjelmare <[email protected]> * Added tests for unloaded state --------- Co-authored-by: Martin Hjelmare <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Following a PR review: #101374 (comment), this changes the setup of the EnergyZero services.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests