Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if heat area exists when setting up valve opening and battery sensors in moehlenhoff alpha2 #105437

Merged
merged 1 commit into from
Dec 10, 2023
Merged

Check if heat area exists when setting up valve opening and battery sensors in moehlenhoff alpha2 #105437

merged 1 commit into from
Dec 10, 2023

Conversation

j-a-n
Copy link
Contributor

@j-a-n j-a-n commented Dec 10, 2023

Proposed change

The XML from the alpha2 xml interface may contain valve opening sensors or battery sensors that refer to non-existent heat areas. This leads to an error when setting up the sensors. With this change, these sensors will be ignored.
#105307

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@j-a-n
Check whether the referenced heat area exists
026b016 
when setting up valve opening and battery sensors
davet2001
davet2001 approved these changes Dec 10, 2023
View reviewed changes
Copy link
Contributor

@davet2001 davet2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks @j-a-n

@MartinHjelmare MartinHjelmare changed the title Check whether the referenced heat area exists when setting up valve opening and battery sensors Check if heat area exists when setting up valve opening and battery sensors in moehlenhoff alpha2 Dec 10, 2023
@MartinHjelmare MartinHjelmare added this to the 2023.12.2 milestone Dec 10, 2023
@MartinHjelmare MartinHjelmare merged commit 77c7226 into home-assistant:dev Dec 10, 2023
20 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davet2001 davet2001 davet2001 approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed integration: moehlenhoff_alpha2 Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2023.12.2
Development

Successfully merging this pull request may close these issues.

Möhlenhoff Alpha 2 integration not working properly after upgrading to 2023.12
4 participants
@j-a-n @davet2001 @frenck @MartinHjelmare