-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2023.12.1 #105324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Erik <[email protected]>
* Bump yolink-api to 0.3.3 * bump yolink api to 0.3.4
* Don't return TTS URL * Add test for empty queue
Fix missing apostrophe
set ping interval to a more sane value of 15 seconds instead of 5 minutes. fixes #105163
* fix supportedFanOscillationModes is null * set default supported_swings to None * return None if no fan oscillation modes listed
* Fix check_date service in workday * Add test
Fix checking for None in Discovergy
Co-authored-by: Franck Nijhof <[email protected]>
* Fix update of uncategorized OurGroceries items * Address code review comments
* Set device id and forward errors * Fix tests
Always set _attr_current_option in select entities.
frenck
requested review from
synesthesiam,
fabaff,
gjohansson-ST,
bdraco,
andrewsayre,
pavoni,
starkillerOG,
jpbede,
iMicknl,
emontnemery,
jbouwh,
Quentame,
a team,
mib1185 and
Kane610
as code owners
December 8, 2023 18:10
home-assistant
bot
added
cla-signed
core
merging-to-master
This PR is merging into the master branch and should probably change the branch to `dev`.
labels
Dec 8, 2023
* Work-a-round orjson for `to_json` fiter in case dict key is str subclass * Add option instead * Remove json.dumps work-a-round * Update homeassistant/helpers/template.py * Fix test --------- Co-authored-by: Erik Montnemery <[email protected]>
jbouwh
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
Thnx for all work!
jpbede
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
starkillerOG
approved these changes
Dec 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla-signed
core
merging-to-master
This PR is merging into the master branch and should probably change the branch to `dev`.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to_json
template filter in parsing dict key (@jbouwh - #105327)Docs PR: home-assistant/home-assistant.io#30227