Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix supportedFanOscillationModes is null #105205

Merged
merged 4 commits into from
Dec 7, 2023
Merged

Fix supportedFanOscillationModes is null #105205

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
566ca5b
fix supportedFanOscillationModes is null
haimn Dec 7, 2023
6f26204
set default supported_swings to None
haimn Dec 7, 2023
c73272f
return None if no fan oscillation modes listed
haimn Dec 7, 2023
813e5a3
Merge branch 'dev' into fix_null_supported_fan_oscillation_modes
haimn Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions homeassistant/components/smartthings/climate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,14 +497,16 @@ def temperature_unit(self) -> str:
"""Return the unit of measurement."""
return UNIT_MAP[self._device.status.attributes[Attribute.temperature].unit]

def _determine_swing_modes(self) -> list[str]:
def _determine_swing_modes(self) -> list[str] | None:
"""Return the list of available swing modes."""
supported_swings = None
supported_modes = self._device.status.attributes[
Attribute.supported_fan_oscillation_modes
][0]
supported_swings = [
FAN_OSCILLATION_TO_SWING.get(m, SWING_OFF) for m in supported_modes
]
if supported_modes is not None:
supported_swings = [
FAN_OSCILLATION_TO_SWING.get(m, SWING_OFF) for m in supported_modes
]
return supported_swings

async def async_set_swing_mode(self, swing_mode: str) -> None:
Expand Down