Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use deprecated_class decorator on deprecated YAML classes #105063

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

emontnemery
Copy link
Contributor

Proposed change

Don't use deprecated_class decorator on deprecated YAML classes

Rationale: The deprecated_class decorator does not handle static or class methods

Note: This PR depends on (and currently includes) #105062

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@emontnemery emontnemery requested a review from a team as a code owner December 5, 2023 09:24
@emontnemery emontnemery marked this pull request as draft December 5, 2023 09:24
@emontnemery emontnemery force-pushed the fix_yaml_loader_deprecation_warning_2 branch from 146fe17 to 59521e5 Compare December 5, 2023 09:49
@emontnemery emontnemery marked this pull request as ready for review December 5, 2023 09:49
@emontnemery emontnemery added this to the 2023.12.0 milestone Dec 5, 2023
@emontnemery emontnemery merged commit 5b59e04 into dev Dec 5, 2023
52 of 53 checks passed
@emontnemery emontnemery deleted the fix_yaml_loader_deprecation_warning_2 branch December 5, 2023 10:36
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants