Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add proj dependency to our wheels builder (#104699)" #104704

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

frenck
Copy link
Member

@frenck frenck commented Nov 29, 2023

Proposed change

This reverts commit 6dc818b from PR #104699

This doesn't work.

https://github.com/home-assistant/core/actions/runs/7031361409/job/19133481825

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added bugfix cla-signed small-pr PRs with less than 30 lines. labels Nov 29, 2023
@frenck frenck marked this pull request as draft November 29, 2023 11:38
@frenck
Copy link
Member Author

frenck commented Nov 29, 2023

Have made some more changes, need to adjust that in this revert. Will do after beta.

@frenck frenck force-pushed the revert-104699-frenck-2023-1481 branch from 114d8e4 to 60af0d0 Compare November 29, 2023 21:22
@frenck frenck added this to the 2023.12.0 milestone Nov 29, 2023
@frenck frenck marked this pull request as ready for review November 29, 2023 21:22
@frenck frenck merged commit ec3795a into dev Nov 29, 2023
53 checks passed
@frenck frenck deleted the revert-104699-frenck-2023-1481 branch November 29, 2023 22:16
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants