-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SMA incorrect device class #101866
Fix SMA incorrect device class #101866
Conversation
Hey there @kellerza, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Can you maybe give examples of what the value can be? |
One of the values is 'Overexcited', don't know exactly what other values this could have. |
Can we maybe figure out what the values can be? In that case we can transform this into an enum device class. |
There is no documentation from SMA that describes this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go with this first, as is immediately addresses a bug that users are experiencing.
Thanks, @rklomp 👍
../Frenck
Proposed change
Will remove
device_class
andstate_class
from grid_power_factor_excitationSensorEntityDescription
The value of this sensor is a string.
Causes issues since 2023.10
See #101643 (comment)
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: