Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LoqedAPI to handle invalid transitions better #101534

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

mikewoudenberg
Copy link
Contributor

@mikewoudenberg mikewoudenberg commented Oct 6, 2023

Proposed change

Updated the LoqedAPI companion library which handles invalid transitions better

cpolhout/loqedAPI@v2.1.7...v2.1.8

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • [] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any releases on GitHub. Would be nice if the upstream package did that, so we can compare changes and see diffs.

../Frenck

@mikewoudenberg
Copy link
Contributor Author

I don't see any releases on GitHub. Would be nice if the upstream package did that, so we can compare changes and see diffs.

../Frenck

I added releases and updated the PR

@frenck
Copy link
Member

frenck commented Oct 6, 2023

I added releases and updated the PR

CleanShot 2023-10-06 at 15 25 29

They don't show up. Something went wrong?

../Frenck

@mikewoudenberg
Copy link
Contributor Author

I added releases and updated the PR

CleanShot 2023-10-06 at 15 25 29

They don't show up. Something went wrong?

../Frenck

I fiddled around with the release thing a bit more and I see them:
Screenshot 2023-10-06 at 15 32 41

@frenck
Copy link
Member

frenck commented Oct 6, 2023

Aah looks like a caching thing @ GitHub or something. If I enter the URLs they are indeed there.

Ok, thanks! 👍

@frenck frenck added this to the 2023.10.1 milestone Oct 6, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mikewoudenberg 👍

../Frenck

@frenck frenck merged commit 83c5844 into home-assistant:dev Oct 6, 2023
@frenck frenck mentioned this pull request Oct 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loqed: Lock keeps a wrong state when calling a service to the current state
2 participants